Waveshare WM8960

Help and Support
#21

The build module in master branch is terribly broken and is nowhere close to get it up and running. After pulling my heir multiple times I finally realized that recent developing activities are moving over volumioOS branch, with kernel version bumped to 5.4.83 – This draws another story as WaveShare patched up their master branch to match API changes in kernel version 5.10.y and will cause compiling error.

I’m putting together a PR to volumioOS branch here and hope we can have this support OOB, but there are still some problems. At this moment, you could try to build your own image based on Debian Buster (kernel 5.4.83+) by checking out volumioOS branch, and then do the following things once you can ssh to the pi:

#!/bin/bash
sudo volumio kernelsource
git clone https://github.com/waveshare/WM8960-Audio-HAT.git
cd WM8960-Audio-HAT
git reset --hard cd5d2e01a80cce929ea64715ed73d1b91cd5ba50
sudo ./install.sh
#22
Moved from Volumio 3 Buster Beta for RPi

I can play pink noise through my audio HAT (Waveshare WM8960 Audio HAT) with speaker-test -Dsysdefault:wm8960-soundcard -c2, but seems like volumio is not getting the correct audio card.

Error Message:
Failed to open ALSA device “volumio”: No such device

HW Configuration:
Raspberry Pi Zero W + Waveshare WM8960 Audio HAT

Image version:
Volumiobuster-3.078-2021-07-01-pi
(Or nightly build, please refer to this PR)

Error Log:
http://logs.volumio.org/volumiobuster/7YXhJy2.html

WM8960 Module install script:
(refer to this post)
wm8960.txt (1.1 KB)

Volumio 3 Buster Beta for RPi
#23

Thanks for your efforts @hftsai256, I see you closed that PR, but I left a note anyway :slight_smile:

#24

Thanks @ashthespy. Before re-open that PR, I think I am going to figure out a structured build system to generate those artifacts and maybe host those binaries in my Github repository.

However there’s a separate issue that Volumio is calling the (at least it is obvious to me) wrong audio device to mpd. Is there any detailed log I can check or can you point out where does the API call take place in Volumio2 repo? I’m not familiar with node.js debugger but have something to print is good enough for me to dig further.

BTW is there a discussion about CI/CD, deployment structure and unit-test framework? I found it quite difficult to trace the development work from READMEs and available documents.

#25

I did manage to get these out-of-tree kernel modules built in containers so that they can be deployed via CI/CD.
But then life and summer came in the way. I’m away from dev machine for a few weeks, but will share when I am back if you are interested.

unit-test what? :stuck_out_tongue:
The motivation behind my rewrite of the build system was to modularise it for ease of development, DRY, and so it can run in containers. Since my normal machines are all Windoze boxes, I build all my images via CircleCI… But, AFAIK the official Voumio images aren’t build by a CI/CD, and runs on Volumio’s servers to include the myVolumio closed source stuff.


When Volumio decides to moves away from Jessie, we should be able to switch the default branch and archive the old stuff, so others don’t spend time as you did.There is some history at [Proposal] Make build system more modular · Issue #413 · volumio/Build · GitHub if you are interested.

It looks like you alsa configuration is wrong and is looking for a MAX98357A instead of the wm8960soundcard ?

pcm.!default {
    type             copy
    slave.pcm       "volumio"
}

pcm.volumio {
    type             copy
    slave.pcm       "volumioOutput"
}


# There is always a plug before the hardware to be safe
pcm.volumioOutput {
    type plug
    slave.pcm "volumioHw"
}

pcm.volumioHw {
    type hw
    card "MAX98357A"
}
#26

Thank you very much for pointing it out. I educated myself to merge the asound.conf with the vender-provided one. The following works beautifully with speaker-test -Dvolumio:

pcm.!default {
    type             copy
    slave.pcm       "volumio"
}

pcm.volumio {
    type             copy
    slave.pcm       "volumioOutput"
}


# There is always a plug before the hardware to be safe
pcm.volumioOutput {
    type plug
    slave.pcm "volumioHw"
}

pcm.volumioHw {
    type copy
    slave.pcm "wm8960"
}

defaults.pcm.rate_converter "samplerate"

pcm.wm8960 {
    type asym
    playback.pcm "playback"
    capture.pcm "capture"
}

pcm.playback {
    type plug
    slave.pcm "dmixed"
}

pcm.capture {
    type plug
    slave.pcm "array"
}

pcm.dmixed {
    type dmix
    slave.pcm "hw:wm8960soundcard"
    ipc_key 555555
}

pcm.array {
    type dsnoop
    slave {
        pcm "hw:wm8960soundcard"
        channels 2
    }
    ipc_key 666666
}

However I’m not feeling good from SW management/engineering aspect, and just as I expected, it would be overriden whenever I change the Audio Output Device in Web Interface.

[Edit] Figured out when the config file is overriden. However it doesn’t seem like to be the case. May you again show me where is the configuration maintained in Volumio backend?

#27

This configuration is normally propagated by the DACS.json file, and should match your definition as per the aplay output…


card 1: wm8960soundcard [wm8960-soundcard], device 0: bcm2835-i2s-wm8960-hifi wm8960-hifi-0 [bcm2835-i2s-wm8960-hifi wm8960-hifi-0]
  Subdevices: 1/1
  Subdevice #0: subdevice #0

From a quick glance at your PR, you might have to update the line you have, as it is for the older v2 version of Volumio.

{ 
"id":"wm8960-soundcard",
"name":"Waveshare - WM8960",
"overlay":"wm8960-soundcard,i2s-mmap",
"alsanum":"1",
"mixer":"",
"modules":"",
"script":"",
"i2c_address":"1a",
"needsreboot":"yes"
},

For the modular Alsa, you need a few more keys in the DAC entry - have a look at Merge ALSA pipeline into buster development by timothyjward · Pull Request #2040 · volumio/Volumio2 · GitHub for more details. Oh and of-course, the back-end code for Buster tree is not master…
EDIT:
Help from Volumio community for a new feature - #29 by ashthespy might also be helpful to figure out the mapping of id, name etc.

#28

Thanks again for the pointers. I’ve figured out the proper json string to wm8960 DAC:

{"id":"wm8960-soundcard",
"name":"Waveshare - WM8960",
"overlay":"wm8960-soundcard,i2s-mmap",
"alsanum":"1",
"alsacard":"wm8960soundcard",
"mixer":"Speaker",
"modules":["i2c-dev","snd-soc-wm8960","snd-soc-wm8960-soundcard"],
"script":"",
"i2c_address":"1a",
"needsreboot":"no"}

However in the current index.js it wouldn’t touch overlay if modules has assigned values. I’d propose to separate modules and overlay control logics such as:

  if (modules) {
    this.config.set('i2s_id', id);
    self.writeModulesFile(modules);
  }
  
  if (overlay) {
    self.revomeAllDtOverlays();
    self.writeI2SDAC(overlay);
    if (script) {
      self.hotAddI2SDAC({'overlay': overlay, 'script': script});
    } else {
      self.hotAddI2SDAC({'overlay': overlay});
    }
    this.config.set('i2s_id', overlay);
  }

[Edit] Volumio2 PR and Build PR are up for discussion.

#29

@hftsai256 Does the upstream wm8960-soundcard overlay not work properly for this board?

I could be wrong, but from a quick look at the commits in wm8960.c, it looks like the clock fixes are now in the upstream codec as well?

#30

I believe it would work, even though the one upstream is slightly different. A quick diff shows:

$ diff -bBw ${rpi-linux}/wm8960-soundcard-overlay.dts ${WM8960-Audio-HAT/wm8960-soundcard.dts
1d0
< // Definitions for Waveshare WM8960 https://github.com/waveshare/WM8960-Audio-HAT
6c5
< 	compatible = "brcm,bcm2835";
---
>     compatible = "brcm,bcm2708";
80a83
>         master = <0>,"=2!3";

AFAIK master override is not doing anything, and bcm2835/bcm2708 are basically the same thing with different packaging.

Looks like the one merged into upstream would detect the proper clock of the device… it is kinda out of my scope to figure out if it works, but my gut tends to believe it.

Unfortunately my wm8960 hat seems to be broken – SW/FW still works, but not sound output from speaker terminal nor headphone jack.

[EDIT] I can confirm that the card is detectable/accessible with upstream overlay dtbo and upstream (fixed) kernel module snd-soc-wm8960.ko only.

#31

With that being said, I was thinking about: being a targeted OS distribution, wouldn’t it make sense to build our own kernel with all in-tree codecs enabled? I can recall there’s an “rpi update” phase during the build to push kernel to version 5.4.83+, and I wonder if we could put in a customized .config file for it.

#32

https://www.waveshare.com/wiki/WM8960_Audio_HAT

#33

This is being done for x86, and the other arm platforms, but for the pi, we try and keep the upstream vanilla kernel.

I’m surprised that PR in the pi repo didn’t enable the kernel module. Oversight? They normally update the kernel config as well from what I recall…

#34

I poked around and was trying to figure out the “no sound” problem on my board while waiting reposes from the issue filed upstream. Turns out in addition to kernel modules (which the two PRs mentioned above have it implemented properly), wm8960_asound.state from official repo has to be applied with a refresh (alsactl nrestore).

Just few minutes ago the issue was responded and the module will be in future kernel builds (yay). Let’s defer implementation details to Github PR thread.